fix: set unique constraint on spaces data

[ameer2468]

Summary by CodeRabbit

• New Features
  • Organization creation now displays a success notification upon completion
  • Users are automatically redirected to the dashboard after creating an organization

[coderabbitai]

Walkthrough

The changes update the spaces data query from select to selectDistinct with removed groupBy, add post-organization-creation navigation to /dashboard/caps with success toast feedback, introduce a new database migration entry, and add a unique constraint on the space_members table for (spaceId, userId).

Changes

Cohort / File(s)	Summary
Dashboard Query Update apps/web/app/(org)/dashboard/dashboard-data.ts	Changed spaces query from select to selectDistinct and removed groupBy clause, eliminating implicit aggregation by spaces.id and users.image
Organization Form Navigation apps/web/components/forms/NewOrganization.tsx	Added router hook and navigation to /dashboard/caps on successful organization creation; success toast displayed on completion
Database Schema Constraint packages/database/schema.ts	Imported unique from drizzle-orm and added unique constraint space_id_user_id_unique on space_members table for (spaceId, userId) pair
Database Migration Metadata packages/database/migrations/meta/_journal.json	Added new journal entry (idx 11, version 5, tag "0011_colorful_hulk") to migration history

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰✨ A query hops from select to distinct,
Forms now guide to caps with a gentle link,
Spaces claim uniqueness with paired constraint,
Migrations journal grows—no feature is faint!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "fix: set unique constraint on spaces data" is specific and clearly reflects the primary technical change in the pull request. The most significant modification is the addition of a unique constraint on the space_members table for (spaceId, userId) in schema.ts, which directly aligns with the title. The supporting changes—including the query modification to use selectDistinct in dashboard-data.ts, the migration journal entry, and the routing updates in NewOrganization.tsx—appear to be related adjustments to properly implement and utilize the new constraint. The title is concise, avoids vague language, and accurately conveys the main intent of the changeset.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch unique-contraint-spaces

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 33840d6 and 21c12bd.

📒 Files selected for processing (4)

• apps/web/app/(org)/dashboard/dashboard-data.ts (2 hunks)
• apps/web/components/forms/NewOrganization.tsx (3 hunks)
• packages/database/migrations/meta/_journal.json (1 hunks)
• packages/database/schema.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx}: Use a 2-space indent for TypeScript code.
Use Biome for formatting and linting TypeScript/JavaScript files by running pnpm format.

Use strict TypeScript and avoid any; leverage shared types

Files:

• apps/web/components/forms/NewOrganization.tsx
• packages/database/schema.ts
• apps/web/app/(org)/dashboard/dashboard-data.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,js,jsx}: Use kebab-case for filenames for TypeScript/JavaScript modules (e.g., user-menu.tsx).
Use PascalCase for React/Solid components.

Files:

• apps/web/components/forms/NewOrganization.tsx
• packages/database/schema.ts
• apps/web/app/(org)/dashboard/dashboard-data.ts

apps/web/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

On the client, always use useEffectQuery or useEffectMutation from @/lib/EffectRuntime; never call EffectRuntime.run* directly in components.

Files:

• apps/web/components/forms/NewOrganization.tsx
• apps/web/app/(org)/dashboard/dashboard-data.ts

apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TanStack Query v5 for all client-side server state and fetching in the web app
Mutations should call Server Actions directly and perform targeted cache updates with setQueryData/setQueriesData
Run server-side effects via the ManagedRuntime from apps/web/lib/server.ts using EffectRuntime.runPromise/runPromiseExit; do not create runtimes ad hoc
Client code should use helpers from apps/web/lib/EffectRuntime.ts (useEffectQuery, useEffectMutation, useRpcClient); never call ManagedRuntime.make inside components

Files:

• apps/web/components/forms/NewOrganization.tsx
• apps/web/app/(org)/dashboard/dashboard-data.ts

apps/web/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Server components needing Effect services must call EffectRuntime.runPromise(effect.pipe(provideOptionalAuth))

Files:

• apps/web/app/(org)/dashboard/dashboard-data.ts

🪛 GitHub Actions: Validate Migrations

packages/database/migrations/meta/_journal.json

[error] 2-2: Migration journal version cannot be changed (was: <BASE_VERSION>, now: <CURRENT_VERSION>)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
• GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
• GitHub Check: Analyze (rust)

🔇 Additional comments (5)

packages/database/schema.ts (2)

22-22: LGTM: Import added for unique constraint.

The unique import is correctly added and properly ordered with other drizzle-orm imports.

---

636-639: Good: Unique constraint prevents duplicate space memberships.

The unique constraint on (spaceId, userId) correctly enforces data integrity by preventing duplicate memberships. Note that a composite index already exists on the same columns (line 632-635), which creates minor redundancy since unique constraints create their own index. This is acceptable and prioritizes data integrity.

packages/database/migrations/meta/_journal.json (1)

82-88: New migration entry format looks correct.

The migration journal entry is properly formatted with all required fields (idx, version, when, tag, breakpoints).

apps/web/components/forms/NewOrganization.tsx (2)

12-12: LGTM: Router hook properly imported and initialized.

The useRouter hook from next/navigation is correctly imported and initialized for client-side navigation in Next.js 15.

Also applies to: 41-41

---

63-65: Verify execution order of navigation vs callback.

The navigation to /dashboard/caps occurs before calling props.onOrganizationCreated(). If the callback performs state updates or cleanup that should complete before navigation, this could cause issues. Consider whether onOrganizationCreated() should be called before or after router.push(), depending on whether it needs to complete synchronously.

Additionally, the path /dashboard/caps is hardcoded. Verify this is the correct destination for all organization creation contexts.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}