Skip to content

fix: eliminate “helicopter” mic stutter by aligning mixer timebase #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

fix: eliminate “helicopter” mic stutter by aligning mixer timebase #1310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a72e60
fix: eliminate “helicopter” mic stutter by aligning mixer timebase
richiemcilroy Oct 28, 2025
b84b43d
fmt
richiemcilroy Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/recording/src/sources/audio_mixer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
Arc,
atomic::{AtomicBool, Ordering},
},
time::{Duration, Instant},

Check warning on line 10 in crates/recording/src/sources/audio_mixer.rs

View workflow job for this annotation

GitHub Actions / Clippy

unused import: `Instant` 

warning: unused import: `Instant`
  --> crates/recording/src/sources/audio_mixer.rs:10:22
   |
10 |     time::{Duration, Instant},
   |                      ^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default
};
use tracing::{debug, info};

Expand Down Expand Up @@ -193,7 +193,15 @@
break;
}

if let Err(()) = mixer.tick(start, Timestamp::Instant(Instant::now())) {
#[cfg(target_os = "macos")]
let now = Timestamp::MachAbsoluteTime(cap_timestamp::MachAbsoluteTimestamp::now());
#[cfg(windows)]
let now =
Timestamp::PerformanceCounter(cap_timestamp::PerformanceCounterTimestamp::now());
#[cfg(not(any(target_os = "macos", windows)))]
let now = Timestamp::Instant(Instant::now());

if let Err(()) = mixer.tick(start, now) {
info!("Mixer tick errored");
break;
}
Expand Down