- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5
basic login screen, server API with all client-sendable message formats #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
        
          
                login/login.html
              
                Outdated
          
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think placeholder would be better as 127.0.0.1 for local server. We can add other servers into the body of the document, if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought initially there was a field for the port. Not sure that it's actually needed since it will always be 4243 for WebSocket, but just making sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Phrancis Yes, originally I had an option in the form for a port, but then I realized that ws:// will always be on a single port, like how http:// is always on port 80.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need for a port field for now, just always use port 4243.
You might want to consider a <select> box with some pre-defined servers, then you could add both dwarftowers.com and 127.0.0.1 to that box.
The place holder for server used to be `dwardtowers.com`, now it is local host. Simon suggested that I add a select option for some of the most common servers. I am planning the best way to do this now.
basic login screen, server API with all client-sendable message formats
No description provided.