Skip to content

Conversation

@acostarelli
Copy link
Contributor

No description provided.

login/login.html Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think placeholder would be better as 127.0.0.1 for local server. We can add other servers into the body of the document, if needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought initially there was a field for the port. Not sure that it's actually needed since it will always be 4243 for WebSocket, but just making sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phrancis Yes, originally I had an option in the form for a port, but then I realized that ws:// will always be on a single port, like how http:// is always on port 80.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need for a port field for now, just always use port 4243.

You might want to consider a <select> box with some pre-defined servers, then you could add both dwarftowers.com and 127.0.0.1 to that box.

The place holder for server used to be `dwardtowers.com`, now it is local host. Simon suggested that I add a select option for some of the most common servers. I am planning the best way to do this now.
Phrancis added a commit that referenced this pull request Jul 28, 2015
basic login screen, server API with all client-sendable message formats
@Phrancis Phrancis merged commit c6031e4 into Cardshifter:master Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants