updating branch #15
Merged
updating branch #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating to most recent code
At some points, the code may try to send a message to the server even though the server is not ready yet. To fix this, the sendMessage method of the server API will now check to make sure that the socket is ready before the message is sent. If the socket is not ready, sendMessage will ---stop drop and roll--- throw a new SocketNotReadyException that contains the current state of the socket
Now, the socket will listen for messages from the server and will stick them into an array. This is all done by the onmessage event of Websocket. Then, when the main game code is ready to accept/receive the server message, it simply needs to call .getMessage, which gets the gets the first message in the messages queue (in actuality, this is the last element of the array), and returns it. This is done easily by using Array.prototype.shift
added exception throwing to sendMessage, added getMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.