Update src/app/features/settings/notifications/notifications.component.ts

improve and shorten conditional

Co-authored-by: nsemets <nsemets@exoft.net>

Author: Johnetordoff

src/app/features/settings/notifications/notifications.component.ts

@@ -137,24 +137,14 @@ export class NotificationsComponent implements OnInit {
   onSubscriptionChange(event: SubscriptionEvent, frequency: SubscriptionFrequency) {
     const user = this.currentUser();
     if (!user) return;
+const apiEventName = this.FORM_EVENT_TO_API_EVENT[event as string] ?? (event as string);
 
-    const eventKey = event as unknown as string;
+    const id =
+      event === SubscriptionEvent.GlobalReviews
+        ? this.notificationSubscriptions().find((s) => (s.event as string) === 'new_pending_submissions')?.id
+        : `${user.id}_${apiEventName}`;
 
-    const apiEventName = this.FORM_EVENT_TO_API_EVENT[eventKey] ?? eventKey;
-
-    let id: string | undefined;
-
-    if (event === SubscriptionEvent.GlobalReviews) {
-      const subs = this.notificationSubscriptions();
-      const match = subs.find((s) => (s.event as string) === 'new_pending_submissions');
-      if (match) {
-        id = match.id;
-      } else {
-        return;
-      }
-    } else {
-      id = `${user.id}_${apiEventName}`;
-    }
+    if (!id) return;
 
     this.loaderService.show();
     this.actions.updateNotificationSubscription({ id, frequency }).subscribe(() => {