feat(registry-overview): establish routing, sidenav, store #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
reviewed
Jun 27, 2025
# Conflicts: # src/app/features/project/overview/components/overview-toolbar/overview-toolbar.component.html
kpetrov24exoft
force-pushed
the
feat/215-registries-overview
branch
from
f68b7bb to
5eeac02
Compare
nsemets
reviewed
Jul 1, 2025
src/app/features/registry/pages/registry-overview/registry-overview.component.scss
Outdated
Show resolved
Hide resolved
src/app/features/registry/pages/registry-overview/registry-overview.component.scss
Outdated
Show resolved
Hide resolved
src/app/features/registry/pages/registry-overview/registry-overview.component.scss
Show resolved
Hide resolved
|
|
||
| <div class="flex gap-4"> | ||
| <div class="left-section gap-4"> | ||
| <!-- TODO: statuses and schema updates--> |
Collaborator
There was a problem hiding this comment.
What this comment for? Is it not finished?
Contributor
Author
There was a problem hiding this comment.
No, currently working on it
| {{ 'registry.overview.updates' | translate }} | ||
| </p-accordion-header> | ||
| <p-accordion-content> | ||
| <div class="content">Important</div> |
src/app/features/registry/models/get-registry-schema-block-json-api.model.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+59
to
+86
|
|
||
| addRegistrationToBookmarks(bookmarksId: string, registryId: string): Observable<void> { | ||
| const url = `${environment.apiUrl}/collections/${bookmarksId}/relationships/linked_registrations/`; | ||
| const payload = { | ||
| data: [ | ||
| { | ||
| type: 'linked_registrations', | ||
| id: registryId, | ||
| }, | ||
| ], | ||
| }; | ||
|
|
||
| return this.#jsonApiService.post<void>(url, payload); | ||
| } | ||
|
|
||
| removeRegistrationFromBookmarks(bookmarksId: string, registryId: string): Observable<void> { | ||
| const url = `${environment.apiUrl}/collections/${bookmarksId}/relationships/linked_registrations/`; | ||
| const payload = { | ||
| data: [ | ||
| { | ||
| type: 'linked_registrations', | ||
| id: registryId, | ||
| }, | ||
| ], | ||
| }; | ||
|
|
||
| return this.#jsonApiService.delete(url, payload); | ||
| } |
Collaborator
There was a problem hiding this comment.
Why registration in collection service?
Contributor
Author
There was a problem hiding this comment.
because we had adding and removeing projects to bookmarks collection so I've also added adding\removing registrations to the same place
…r-osf into feat/215-registries-overview # Conflicts: # src/app/features/project/overview/components/overview-toolbar/overview-toolbar.component.html # src/app/features/project/overview/components/overview-toolbar/overview-toolbar.component.ts
nsemets
approved these changes
Jul 1, 2025
…r-osf into feat/215-registries-overview # Conflicts: # src/app/core/components/nav-menu/nav-menu.component.ts # src/app/features/collections/store/collections.actions.ts # src/app/features/collections/store/collections.state.ts # src/app/features/my-projects/services/my-projects.service.ts # src/app/shared/components/index.ts # src/app/shared/models/index.ts # src/assets/i18n/en.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit: [establish routing, sidenav, store]
commit: [mapper, get bookmarks, overview-toolbar]