My registrations page #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feat/262-my-registration
…to feat/262-my-registration
nsemets
reviewed
Jul 14, 2025
| public draftId: string, | ||
| public attributes: Partial<RegistrationAttributesJsonApi>, | ||
| public relationships?: Partial<RegistrationRelationshipsJsonApi> | ||
| public attributes: Partial<DraftRegistrationAttributesJsonApi>, |
Collaborator
There was a problem hiding this comment.
Can we use here not JsonApi model?
Contributor
Author
There was a problem hiding this comment.
I guess no, but I double-check
src/app/features/registries/pages/my-registrations/my-registrations.component.html
Outdated
Show resolved
Hide resolved
src/app/features/registries/pages/my-registrations/my-registrations.component.html
Outdated
Show resolved
Hide resolved
src/app/features/registries/pages/my-registrations/my-registrations.component.ts
Show resolved
Hide resolved
| private router = inject(Router); | ||
| private readonly route = inject(ActivatedRoute); | ||
|
|
||
| private readonly translateService = inject(TranslateService); |
Collaborator
There was a problem hiding this comment.
Not used here. Remove it.
|
|
||
| export interface RegistrationsStateModel { | ||
| registrations: AsyncStateModel<RegistrationModel[]>; | ||
| registrations: AsyncStateModel<RegistrationCard[]> & { |
Collaborator
There was a problem hiding this comment.
Use AsyncStateWithTotalCount.
nsemets
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.