[ENG-8505] Updates to continue to prepare for the addition of GFP #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
reviewed
Aug 21, 2025
| '<rootDir>/src/app/features/project/analytics/', | ||
| '<rootDir>/src/app/features/project/contributors/', | ||
| '<rootDir>/src/app/features/files/', | ||
| '<rootDir>/src/app/features/project/files/', |
Collaborator
There was a problem hiding this comment.
We don't have files in project. It was moved from project folder.
Collaborator
There was a problem hiding this comment.
@bp-cos just fix this.
Suggested change
| '<rootDir>/src/app/features/project/files/', | |
| '<rootDir>/src/app/features/files/', |
bp-cos
force-pushed
the
feature/eng-8505
branch
from
7940b7c to
0238bad
Compare
nsemets
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Updates to tests, testing structure and documentation
Summary of Changes
1- Added a test for the
app/shared/services/addons/addons.service.ts2- Added compodoc to facilitate better documentation
3- Added a warning to the pre-commit husky to verify coverage
4- Added a README for compodoc. The language is for a future day when documentation hits 100%
5- Add an
osf.testing.module.tsas an abstracted import to simplify unit testing6- Added a src/testing/data directory to hold all of the test data. In ember, the test data was built using mirage. In angular it is all static files. This is the initial commit to start building up the data sets. There is a question about how much data really needs to be included. Do we really need all 10 objects?
7- Installed 'structuredClone` to facilitate the testing data stays constant.
8- Added a *.d.ts type file to @types for structuredClone
Screenshot(s)
N/A
Side Effects
N/A
QA Notes
None required for this ticket.