[eng-8505] Add logic to get the external storage addon in the state model. #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
reviewed
Aug 22, 2025
src/app/features/project/addons/components/configure-addon/configure-addon.component.html
Show resolved
Hide resolved
nsemets
reviewed
Aug 22, 2025
|
|
||
| beforeEach(() => { | ||
| TestBed.configureTestingModule({ | ||
| imports: [NgxsModule.forRoot([AddonsState])], |
Collaborator
There was a problem hiding this comment.
We use standalone components, so I would prefer to use provideStore.
nsemets
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To activate the GFP on the configure page, the component needs to know the external storage addon wb key.
Summary of Changes
Added tests for TTD
Added extended the addon and configured addon models
Added and refactored to models to have the
Modelat the end since I was getting so confused between the state and the model, etc.Add documentation
Started a pattern of testing the action/state/selector all in one test since the action isn't viable to test in isolation. The selector is garbage in/garbage out. So lumping the action and selector tests with the state test feels like the way to go.
It also allows for testing of the loading selector and any other selectors used by the action.
Starting to really love the flow of the angular ecosystem.