[ENG-8505] Add the ability to select a folder with oauth working #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
approved these changes
Sep 3, 2025
Comment on lines
+11
to
+12
| import { GoogleFileDataModel } from '@osf/shared/models/files/google-file.data.model'; | ||
| import { GoogleFilePickerModel } from '@osf/shared/models/files/google-file.picker.model'; |
Collaborator
There was a problem hiding this comment.
It would be better to import them from index.ts
| protected hasInputChanged = signal(false); | ||
| protected hasFolderChanged = signal(false); | ||
| protected selectedRootFolder = signal<StorageItem | null>(null); | ||
| public selectedRootFolder = signal<StorageItemModel | null>(null); |
Collaborator
There was a problem hiding this comment.
Do we need to set public if it by default public?
Merged
via the queue into
CenterForOpenScience:main
with commit Sep 3, 2025
cf5041d
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ENG-8505] Add the ability to select a folder with oauth working
Purpose
Have the GFP work with oauth
Summary of Changes
Updated all the payload for Oauth to work with tests
Add the method to the child component to select a folder with tests
Add a few new models
Screenshot(s)
Side Effects
None
QA Notes
Test away