Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Oct 23, 2025

  • Ticket: [ENG-9612]
  • Feature flag: n/a

Purpose

  • Get tests running on Github Actions again
  • streamline some pain-points we have in our current workflow

Summary of Changes

  • Remove tests running before every push
  • Remove confusing copies of Branch Rules.json that weren't actually setting the branch rules (they were just copies of the actual rules that you set in Github)
  • Remove review.yml as this is already covered by our repository settings and is redundant
  • Get tests running in Github Actions again (this was manually turned off in the "Actions" tab in Github, so none of the code changes in the test.yml file are technically needed)

Screenshot(s)

  • NA

Side Effects

QA Notes

@futa-ikeda futa-ikeda changed the title [HOLD] Feature/gha [ENG-9612] Github Actions Oct 23, 2025
@brianjgeiger
Copy link
Contributor

@futa-ikeda Could you give a thumbs up for this to cover my merge of the last PR?

@futa-ikeda
Copy link
Contributor Author

Ah, seems I can't approve my own PRs. Will pester someone else for an approval

@brianjgeiger brianjgeiger merged commit 06b8657 into develop Oct 24, 2025
3 checks passed
@futa-ikeda futa-ikeda deleted the feature/gha branch October 24, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants