[ENG-9749] Navigation Project Addons page → Linked Services (from dropdown box) causes an infinite loading loop. #756
Conversation
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
A couple of comments regarding drag and drop that I don't think are relevant because I'm pretty sure you can't drag and drop across providers in the current interface. Otherwise looks good.
| [value]="nodes()" | ||
| [draggableNodes]="true" | ||
| [droppableNodes]="true" | ||
| [draggableNodes]="!hasViewOnly() && supportUpload()" |
There was a problem hiding this comment.
If supportUpload menas that the current storage provider can be uploaded to, I don't think that's correct. You should be able to drag from any provider you can read from, but you can only drop on providers that support uploads.
There was a problem hiding this comment.
As below, if you can't drag and drop between providers, then this may not matter and can remain as it is.
There was a problem hiding this comment.
Here are conditions for supportUpload(): this.supportedFeatures()[this.provider()]?.includes(SupportedFeature.AddUpdateFiles) && this.canEdit() && !this.isRegistration(). Also, it's a drag-and-drop action within the same provider, not between different providers.
There was a problem hiding this comment.
Okay, should be fine then.
| [draggableNodes]="true" | ||
| [droppableNodes]="true" | ||
| [draggableNodes]="!hasViewOnly() && supportUpload()" | ||
| [droppableNodes]="!hasViewOnly() && supportUpload()" |
There was a problem hiding this comment.
Also note that some providers (well, Github, but potentially others) have a "Can copy into" flag disabled from the addons service capabilities list. This means that you can't copy into those providers. This may not matter for drag and drop, because I don't think you can drag to another provider, but if you can, then this would be disabled in some other cases.
brianjgeiger
merged commit 16cc0bf
into
CenterForOpenScience:feature/pbs-25.04
3 participants
Summary of Changes