chore(157): project-addons-ui #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
reviewed
May 29, 2025
src/app/shared/components/addons/addon-card/addon-card.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/addons/addon-card/addon-card.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/addons/addon-card/addon-card.component.scss
Outdated
Show resolved
Hide resolved
| return this.currentAddonsState().filter((card) => card.externalServiceName.includes(searchValue)); | ||
| }); | ||
|
|
||
| protected readonly tabOptions: SelectOption[] = [ |
Collaborator
There was a problem hiding this comment.
Move it to constants file. Also better to use enum instead of 1 and 0. It's not clear what these number means.
| }, | ||
| ]; | ||
|
|
||
| protected readonly categoryOptions: SelectOption[] = [ |
Collaborator
There was a problem hiding this comment.
Move it to constants file. Also better to use enum.
| @use "assets/styles/variables" as var; | ||
|
|
||
| :host { | ||
| @include mix.flex-column; |
Collaborator
There was a problem hiding this comment.
Use prime flex instead of this mix
| export class AddonsComponent { | ||
| #store = inject(Store); | ||
| protected readonly defaultTabValue = 0; | ||
| protected readonly isMobile = toSignal(inject(IS_XSMALL)); |
Collaborator
There was a problem hiding this comment.
Remove this and make it with primeflex.
nsemets
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.