fix(account-settings): confirm email #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
reviewed
Jun 4, 2025
src/app/features/home/components/confirm-email/confirm-email.component.ts
Outdated
Show resolved
Hide resolved
...atures/settings/account-settings/components/connected-emails/connected-emails.component.html
Outdated
Show resolved
Hide resolved
Collaborator
There was a problem hiding this comment.
Why not use store instead of service directly?
Contributor
Author
There was a problem hiding this comment.
if request doesn't affect store, I use service directly, for example request to resend confirmation email
Contributor
Author
There was a problem hiding this comment.
though for makePrimary(), I should change it to use store
Collaborator
There was a problem hiding this comment.
Why dispatch an action in state?
Contributor
Author
There was a problem hiding this comment.
because ater I add new email, I need automatically update list of emails and for consistency it's better to get them from server
nsemets
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.