Skip to content

[ENG-3108][ENG-3159] Fix a11y for display list in node card by removing divs #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2021
Merged

[ENG-3108][ENG-3159] Fix a11y for display list in node card by removing divs #1268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b8de73
Fix a11y for display list in node card by removing divs
brianjgeiger Aug 26, 2021
5ec90fc
Merge branch 'develop' into feature/node-card-a11y-dl
brianjgeiger Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 50 additions & 67 deletions lib/osf-components/addon/components/node-card/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,80 +98,63 @@
{{#if @node}}
<dl>
{{#if @node.isRegistration}}
<div data-test-registration-template-name>
<dt data-test-registration-template-label>
{{t 'node_card.registration_template'}}
</dt>
<dd>
{{@node.registrationSchema.name}}
</dd>
</div>
<div data-test-registration-registry>
<dt data-test-registration-registry-label>
{{t 'node_card.registry'}}
</dt>
<dd data-test-registration-registry-name>
{{@node.provider.name}}
</dd>
</div>
{{/if}}
<div data-test-created-timestamp>
<dt data-test-created-timestamp-label>
{{t (concat 'node_card.' @node.nodeType '.timestamp_label')}}
<dt data-test-registration-template-label>
{{t 'node_card.registration_template'}}
</dt>
<dd data-test-created-timestamp-value>
{{moment @node.dateCreated}}
</dd>
</div>
<div data-test-updated-timestamp>
<dt data-test-updated-timestamp-label>
{{t 'node_card.last_updated'}}
<dd data-test-registration-template-name>
{{@node.registrationSchema.name}}
</dd><br />
<dt data-test-registration-registry-label>
{{t 'node_card.registry'}}
</dt>
<dd data-test-updated-timestamp-value>
{{moment @node.dateModified}}
</dd>
</div>
<div data-test-contributors>
<dt
data-test-contributors-label
<dd data-test-registration-registry-name>
{{@node.provider.name}}
</dd><br />
{{/if}}
<dt data-test-created-timestamp-label>
{{t (concat 'node_card.' @node.nodeType '.timestamp_label')}}
</dt>
<dd data-test-created-timestamp-value>
{{moment @node.dateCreated}}
</dd><br />
<dt data-test-updated-timestamp-label>
{{t 'node_card.last_updated'}}
</dt>
<dd data-test-updated-timestamp-value>
{{moment @node.dateModified}}
</dd><br />
<dt
data-test-contributors-label
>
{{t 'node_card.contributors'}}
</dt>
<dd>
<ContributorList
@model={{@node}}
@shouldLinkUsers={{true}}
/>
</dd><br />
<dt
data-test-description-label
>
{{t 'node_card.description'}}
</dt>
<dd data-test-description local-class='NodeCard__description'>
{{@node.description}}
</dd><br />
{{#if (and this.showTags @node.tags)}}
<dt local-class='NodeCard__tags'
data-test-tags-label

>
{{t 'node_card.contributors'}}
{{t 'node_card.tags'}}
</dt>
<dd>
<ContributorList
@model={{@node}}
@shouldLinkUsers={{true}}
<TagsWidget
@taggable={{@node}}
@inline={{true}}
/>
</dd>
</div>
<div data-test-description>
<dt
data-test-description-label
>
{{t 'node_card.description'}}
</dt>
<dd local-class='NodeCard__description'>
{{@node.description}}
</dd>
</div>
{{#if (and this.showTags @node.tags)}}
<div
data-test-tags
local-class='NodeCard__tags'
>
<dt
data-test-tags-label

>
{{t 'node_card.tags'}}
</dt>
<dd>
<TagsWidget
@taggable={{@node}}
@inline={{true}}
/>
</dd>
</div>
{{/if}}
</dl>
<OsfLink
Expand Down