Skip to content

[ENG-3198][ENG-3199] A11y fixes for submitted registration page #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2021
Merged

[ENG-3198][ENG-3199] A11y fixes for submitted registration page #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc08e54
A11y fixes
brianjgeiger Sep 17, 2021
996cab5
Merge branch 'develop' into feature/submitted-registration-a11y
brianjgeiger Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-components/addon/components/registries/registration-form-navigation-dropdown/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
line-height: 2.8;
}

.ToggleNav__button:global(.btn.btn-link) {
.ToggleNav__button {
float: right;
color: $color-text-blue-dark;
padding: 3px 8px;
Expand Down
17 changes: 8 additions & 9 deletions ...components/addon/components/registries/registration-form-navigation-dropdown/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
{{assert 'Registries::RegistrationFormNavigationDropdown requires schemablocks' @schemaBlocks}}
<ResponsiveDropdown local-class='Dropdown' @renderInPlace={{true}} as |dd|>
<dd.trigger local-class='MenuTrigger'>
<BsButton
data-analytics-name='Expand'
data-test-toggle-anchor-nav-button
local-class='ToggleNav__button'
aria-label={{t 'registries.drafts.draft.review.toggle_dropdown'}}
@type='link'
>
<dd.trigger
local-class='MenuTrigger'
data-test-toggle-anchor-nav-button
data-analytics-name='Expand'
aria-label={{t 'registries.drafts.draft.review.toggle_dropdown'}}
>
<div local-class='ToggleNav__button'>
<FaIcon @icon='bars' />
</BsButton>
</div>
</dd.trigger>
<dd.content>
<nav
Expand Down
2 changes: 1 addition & 1 deletion lib/osf-components/addon/components/side-nav/x-link/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ $sidenav-link-height: 40px;
}

.Count {
color: $color-text-slate-gray;
color: $color-text-gray;
font-weight: 700;
}

Expand Down
7 changes: 7 additions & 0 deletions lib/registries/addon/overview/-components/overview-topbar/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<ResponsiveDropdown as |dd|>
<dd.trigger
data-test-forks-dropdown-button
aria-label={{t 'registries.overview.tooltips.fork'}}
data-analytics-name='Expand fork dropdown'
local-class='Action'
>
Expand Down Expand Up @@ -61,6 +62,11 @@
@type='link'
@onClick={{action (perform this.bookmark)}}
local-class='ActionButton'
aria-label={{if
this.isBookmarked
(t 'registries.overview.tooltips.remove_bookmark')
(t 'registries.overview.tooltips.bookmark')
}}
>
<FaIcon
local-class='Icon'
Expand Down Expand Up @@ -91,6 +97,7 @@
data-test-social-sharing-button
data-analytics-name='Expand sharing menu'
local-class='Action'
aria-label={{t 'registries.overview.tooltips.share'}}
>
<FaIcon
local-class='Icon'
Expand Down
2 changes: 1 addition & 1 deletion tests/engines/registries/acceptance/overview/overview-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ module('Registries | Acceptance | overview.overview', hooks => {
) && displayText);
await visit(`/${reg.id}/`);

assert.dom('[data-test-toggle-anchor-nav-button]').isVisible();
assert.dom('[data-test-toggle-anchor-nav-button] div').isVisible();
assert.dom('[data-test-page-anchor]').isNotVisible();

await click('[data-test-toggle-anchor-nav-button]');
Expand Down