Skip to content

[ENG-3237][ENG-3238] Fix accessibility problems on collections submission page #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2021
Merged

[ENG-3237][ENG-3238] Fix accessibility problems on collections submission page #1315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ea2698
Fix accessibility problems on collections submission page
brianjgeiger Sep 29, 2021
5b41480
Merge branch 'develop' into feature/collections-submission-a11y
brianjgeiger Nov 3, 2021
2da0b06
Remove unused code
brianjgeiger Nov 4, 2021
6f5c98a
Merge branch 'develop' into feature/collections-submission-a11y
brianjgeiger Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/app-components/addon/components/project-contributors/list/item/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@
height: 30px;
}

.checkbox-label {
font-weight: normal;
padding-right: 5px;
}

@media (min-width: 768px) {
.text-sm-center {
text-align: center;
Expand Down
13 changes: 6 additions & 7 deletions lib/app-components/addon/components/project-contributors/list/item/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,12 @@
{{! Bibliographic (Citation) }}
<div data-test-project-contributors-list-item-citation-checkbox local-class='text-sm-center'
class='col-xs-10 col-sm-2 col-sm-offset-0 bib-padding'>
<label local-class='checkbox-label' class='visible-xs-inline' for='{{@contributor.id}}-citation'>
<em>
{{t 'app_components.project_contributors.list.item.in_citation_label'}}
</em>
</label>
<Input @id={{concat @contributor.id '-citation'}} @type='checkbox' @disabled={{not this.canChangeBibliographic}}
@checked={{@contributor.bibliographic}} @change={{action @toggleBibliographic @contributor}} />
<Input
aria-label={{t 'app_components.project_contributors.list.item.in_citation_label'}}
@type='checkbox'
@disabled={{not this.canChangeBibliographic}}
@checked={{@contributor.bibliographic}}
@change={{action @toggleBibliographic @contributor}} />
</div>

{{! Remove }}
Expand Down
2 changes: 2 additions & 0 deletions lib/app-components/addon/components/project-contributors/search/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@
class='input-group'
>
<Input
aria-label={{t 'app_components.project_contributors.search.placeholder'}}
@class='form-control'
@value={{this.query}}
@placeholder={{t 'app_components.project_contributors.search.placeholder'}}
/>
<span class='input-group-btn'>
<button
data-test-project-contributors-search-button
aria-label={{t 'app_components.project_contributors.search.perform_search'}}
local-class='authors-search-button'
class='btn btn-default'
type='submit'
Expand Down
2 changes: 1 addition & 1 deletion lib/app-components/addon/components/submit-section/active/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.closed {
color: #888;
color: $color-text-black;
}

.green {
Expand Down
1 change: 1 addition & 0 deletions translations/en-us.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,7 @@ app_components:
add: Add
add_contributor_success: 'Project contributor added!'
add_contributor_error: 'Could not add contributor.'
perform_search: 'Perform search'
project_metadata:
field_title_label: 'Title:'
field_title_placeholder: ""
Expand Down