Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 17, 2021

Purpose

  • Simplify the HTML that is rendered for draft-registration card and node-cards to prevent weird artifacts when hovering, and also better tab-navigation UX

Summary of Changes

  • Un-nested some html that was causing issues when hovering these buttons/links, as well as causing tab-focus on these buttons/links to be caught twice
  • style these links to look like <Button>s

Screenshot(s)

Node Cards:

  • This should no longer have a little line poking out of the right-side of the button when hovering the View button

  • Before

    • image
  • After

    • image

Draft Registration Cards:

  • This should look the exact same for mouse and keyboard, but should no longer focus in a weird way when users tab into focus

  • Before

    • image
  • After

    • image

Side Effects

  • none

QA Notes

  • This should eliminate the little bit that pokes out on the View button of the node cards on the Submitted tab of MyRegistrations and Registrations tab of Project Registrations page
  • This should also eliminate an extra tab-keypress that would happen for the Review and Edit buttons of the draft-registration cards on the Drafts/Draft Registrations tab

@futa-ikeda futa-ikeda changed the base branch from develop to release/21.10.0 November 17, 2021 22:18
@coveralls
Copy link

coveralls commented Nov 17, 2021

Pull Request Test Coverage Report for Build 1481699887

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.083%

Totals Coverage Status
Change from base Build 1481491118: 0.0%
Covered Lines: 5160
Relevant Lines: 6795

💛 - Coveralls

@futa-ikeda futa-ikeda requested a review from adlius November 18, 2021 14:47
@adlius adlius merged commit 9f09d9e into CenterForOpenScience:release/21.10.0 Nov 19, 2021
@futa-ikeda futa-ikeda deleted the node-card-and-draft-card-tweaks branch November 19, 2021 17:02
@adlius adlius added this to the 21.10.0 milestone Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants