Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 18, 2021

Purpose

  • Move the Delete Revision button in the edit revision workflow
  • Remove Updated responses list from the Justification page of the edit-revision workflow
  • Add Delete Draft button to the draft registration workflow

Summary of Changes

Screenshot(s)

  • Draft Registration workflow:

    • image
  • Revision workflow:

    • image

Side Effects

  • None

QA Notes

  • We will no longer validate whether or not responses have been updated on the FE. When submitting an update, the backend should validate that, and if there are no updated responses, the revision shouldn't be able to be submitted

@futa-ikeda futa-ikeda force-pushed the migration-of-the-cancel-button branch from 53df3fa to bc28dbc Compare November 19, 2021 15:01
{{#if @revisionManager.showDeleteButton}}
<DeleteButton
local-class='DeleteButton'
@delete={{perform @onDelete}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have access to @revisionManager. Would it be a good idea to add the delete task to eliminate the need for an extra parameter to be passed in to right-nav?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels much more appropriate to live on the revisionManager. I will do that now!

@coveralls
Copy link

coveralls commented Nov 19, 2021

Pull Request Test Coverage Report for Build 1481955463

  • 9 of 15 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 73.131%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/registries/addon/drafts/draft/draft-registration-manager.ts 3 6 50.0%
lib/registries/addon/edit-revision/revision-manager.ts 5 8 62.5%
Totals Coverage Status
Change from base Build 1481904705: 0.05%
Covered Lines: 5167
Relevant Lines: 6800

💛 - Coveralls

@adlius adlius merged commit fe1b2e0 into CenterForOpenScience:release/21.10.0 Nov 19, 2021
@futa-ikeda futa-ikeda deleted the migration-of-the-cancel-button branch November 19, 2021 18:01
@adlius adlius added this to the 21.10.0 milestone Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants