[ENG-3243][ENG-3417] Revisions bugfixes

[futa-ikeda]

• Ticket: ENG-3243 ENG-3417
• Feature flag: n/a

Purpose

• Address various bugs found in Revisions workflow

Summary of Changes

• Darken color contrast for create buttons (3.41 -> 5.33 : 1, passes AA)
• Small wording changes
• Auto-close the dropdown when selecting a revision on the overview page
• Add data-test selectors to delete button modal for automated testing

Screenshot(s)

Side Effects

• All create buttons will have better color contrast!

QA Notes

[coveralls]

Pull Request Test Coverage Report for Build 1496329879

• 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.005%) to 73.127%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/osf-components/addon/components/registries/update-dropdown/component.ts	0	2	0.0%

Totals
Change from base Build 1482079344:	0.005%
Covered Lines:	5169
Relevant Lines:	6802

---

💛 - Coveralls

[futa-ikeda]

I tried to do something more simple like @onClick={{dd.close}}, but doing so caused the page to do a full load every time. I don't think this is the best way of closing the dropdown on click, but other attempts have either run into the problem where it does a full app load as opposed to a transition, or doesn't show which revision is the currently selected one (like when using <OsfLink>

[adlius]

Is there any reason why it does a full page load ?

[futa-ikeda]

I'm not exactly sure why. I tried messing around with some different approaches, but basically anything that closed the dropdown before the transition finished would trigger a full page load. I'm guessing there's something about how the transition is being called that gets messy when the dropdown is closed, but I couldn't quite figure out how to remedy that.