Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Dec 15, 2021

Purpose

  • Reroute users out of the draft registration edit route to the overview page if a draft has already been submitted

Summary of Changes

Screenshot(s)

NA

Side Effects

None

QA Notes

  • This should only impact drafts that have already been submitted when going to osf.io/registries/drafts/<draft_that_is_already_submitted>

@coveralls
Copy link

coveralls commented Dec 15, 2021

Pull Request Test Coverage Report for Build 1584416943

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 73.157%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/registries/addon/drafts/draft/route.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 1583702333: -0.02%
Covered Lines: 5176
Relevant Lines: 6812

💛 - Coveralls

brianjgeiger
brianjgeiger previously approved these changes Dec 15, 2021
Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did product approve the language?

@adlius adlius merged commit 830472f into CenterForOpenScience:develop Dec 17, 2021
@adlius adlius added this to the 21.11.0 milestone Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants