[ENG-700] Fix node-card date for older registrations

[futa-ikeda]

• Ticket: ENG-700
• Feature flag: n/a

Purpose

• Currently the node-card component (used on a project's registration page and the my-registrations page) is saying that a Registration was registered when the backing project was created. For older (not exactly sure how old), project-based registrations, this will not be true and will lead to user confusion.

Summary of Changes

• Change the date we are showing from the registration.dateCreated (date created of backing project), to registration.dateRegistered (when the registration was actually registered)
• Update tests

Screenshot(s)

Before: NodeCard shows "Registered" as date created

Before: Registration overview page shows correct dates

After: NodeCard shows "Registered" as date registered

After:

Side Effects

• None

QA Notes

• I'm not too sure when the dateCreated for Registrations went from a timestamp of when the backing project was created to when the registration itself was created, so you may need a fairly old registration to test this. There is a project with registrations that show this behavior on production here: https://osf.io/2nj9h/registrations (Note: all of these registrations were supposedly registered on Jan 12, 2016. Checking the API for each of these registrations will show that these were registered at separate times)
• As a side-note: Newer registrations have dateCreated === dateRegistered. We show both of these dates on the overview page, so it looks a little weird, but at least we're not lying about the date registered.

[coveralls]

Pull Request Test Coverage Report for Build 1814176853

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 73.157%

---

Totals
Change from base Build 1814175359:	0.0%
Covered Lines:	5176
Relevant Lines:	6812

---

💛 - Coveralls