[ENG-3880] Add file tests #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2580064259
💛 - Coveralls |
brianjgeiger
requested changes
Jun 28, 2022
Contributor
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
A couple of questions, one missing data-analytics-name, and an errant commented bit of code.
Comment on lines
6
to
7
| data-test-bulk-delete-trigger | ||
| @type='destroy' |
Contributor
There was a problem hiding this comment.
Looks like we could use a data-analytics-name here.
| import { setupMirage } from 'ember-cli-mirage/test-support'; | ||
| import { t } from 'ember-intl/test-support'; | ||
| import { TestContext } from 'ember-test-helpers'; | ||
| // import { percySnapshot } from 'ember-percy'; |
Contributor
There was a problem hiding this comment.
Probably don't need this comment (or we should add a snapshot, whichever is more appropriate)
Contributor
|
These look really great Futa. We approached testing a bit differently with the Node Model instance, but this may be better. I just ran checks again and all looks good. Well done! |
chth0n1x
previously approved these changes
Jun 28, 2022
brianjgeiger
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes
data-test-bulk-copy-trigger,data-test-bulk-move-trigger, anddata-test-bulk-delete-triggerdata-test-add-new-trigger