Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Jul 5, 2022

Purpose

  • Disallow special characters in new folders and file/folder rename modals

Summary of Changes

  • Add logic to check against forbidden special chars for file rename and new folder modal
  • Add error messages to those modals

Screenshot(s)

  • Rename
    • Desktop:

    • image

    • Mobile:

    • image

  • New folder
    • Desktop
    • image
    • Mobile
    • image

Side Effects

  • Renaming existing files/folders that already have special characters will need to have those special characters removed

QA Notes

  • The special characters that we disallow are ()<>~!@$&*:;,'"|/?
  • For a more detailed breakdown of which providers have trouble with specific characters, please check the JIRA ticket

@coveralls
Copy link

coveralls commented Jul 5, 2022

Pull Request Test Coverage Report for Build 2657477568

  • 23 of 24 (95.83%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 70.941%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/osf-components/addon/components/file-browser/file-rename-modal/component.ts 11 12 91.67%
Totals Coverage Status
Change from base Build 2657475672: 0.4%
Covered Lines: 5261
Relevant Lines: 7205

💛 - Coveralls

Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny text changes and one additional test requested.

@futa-ikeda futa-ikeda merged commit e93ea45 into CenterForOpenScience:develop Jul 12, 2022
@futa-ikeda futa-ikeda deleted the file-name-special-chars branch July 12, 2022 15:48
@adlius adlius added this to the 22.7.0 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants