Skip to content

[ENG-4598] Try initializing GTM in a way that works runtime #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[ENG-4598] Try initializing GTM in a way that works runtime #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/environment.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ declare const config: {
rootURL: string;
assetsPrefix: string;
sentryDSN: string | null;
googleTagManagerId: string | null;
sentryOptions: {
release?: string;
ignoreErrors: string[];
Expand Down Expand Up @@ -195,7 +196,6 @@ declare const config: {
pageTitle: {
prepend: boolean;
};
gtm: string;
};

export default config;
2 changes: 1 addition & 1 deletion config/environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ module.exports = function(environment) {
assetsPrefix,
locationType: 'auto',
sentryDSN: null,
googleTagManagerId: null,
sentryOptions: {
release,
ignoreErrors: [
Expand Down Expand Up @@ -303,7 +304,6 @@ module.exports = function(environment) {
pageTitle: {
prepend: false,
},
gtm: '<script></script>',
};

if (environment === 'development') {
Expand Down
13 changes: 12 additions & 1 deletion ember-cli-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,18 @@ module.exports = function(defaults) {
},
gtm: {
enabled: IS_PROD,
content: config.gtm,
content: `<script>
var configJson = document.head.querySelector("meta[name$='/config/environment']").content;
var configObject = JSON.parse(unescape(configJson));
if (configObject.googleTagManagerId) {
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());
Copy link
Contributor

@futa-ikeda futa-ikeda Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is relevant, but on prod it looks like this is gtm.js and not js 🤷

Copy link
Contributor Author

@brianjgeiger brianjgeiger Aug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯\(ツ)/¯


gtag('config', configObject.googleTagManagerId);
}
</script>
`,
postProcess,
},
},
Expand Down