Skip to content

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Feb 27, 2024

Purpose

  • Add a new helper to avoid having to make unneeded component.ts and controller.ts files

Summary of Changes

  • Create new is-mobile helper
  • Test for new helper
  • Not currently implemented in actual pages

Screenshot(s)

  • NA

Side Effects

  • None

QA Notes

  • No QA needed as nothing functional is changing

@futa-ikeda futa-ikeda changed the title Add is-mobile helper [ENG-5318] Add is-mobile helper Feb 27, 2024
@futa-ikeda
Copy link
Contributor Author

Hmm, this actually seems redundant based on what is in the ember-responsive docs

{{#if (media 'isDesktop')}}
  Desktop view!
{{/if}}

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple of comments/questions

@bp-cos bp-cos merged commit 386ce83 into CenterForOpenScience:feature/preprints-phase-2 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants