-
Notifications
You must be signed in to change notification settings - Fork 63
ENG-3764 A11y - OSF Home/Landing Page #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-3764 A11y - OSF Home/Landing Page #2175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good, but you've broken a test. Integration | Component | carousel: li navigation works
@brianjgeiger Fixed the failing test to match the updated div-based navigation. Carousel should be all set now. |
Pull Request Test Coverage Report for Build 8512978031Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Purpose
Fix a11y issue for carousel by removing nested interactive controls
Summary of Changes
Screenshot(s)
QA Notes