Skip to content

Conversation

uditijmehta
Copy link
Contributor

@uditijmehta uditijmehta commented Mar 28, 2024

Purpose

Fix a11y issue for carousel by removing nested interactive controls

Summary of Changes

  • Replaced 'li' elements with 'div' for carousel navigation
  • Adjusted CSS to apply styles to the new 'div' structure
  • Updated TypeScript logic to manage active state

Screenshot(s)

QA Notes

Copy link
Contributor

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good, but you've broken a test. Integration | Component | carousel: li navigation works

@uditijmehta
Copy link
Contributor Author

@brianjgeiger Fixed the failing test to match the updated div-based navigation. Carousel should be all set now.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8512978031

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 68.147%

Files with Coverage Reduction New Missed Lines %
lib/osf-components/addon/components/carousel/x-item/component.ts 1 72.22%
Totals Coverage Status
Change from base Build 8345343041: -0.03%
Covered Lines: 6139
Relevant Lines: 8760

💛 - Coveralls

Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@brianjgeiger brianjgeiger merged commit 1150dc6 into CenterForOpenScience:develop Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants