Skip to content

Conversation

@baylee-d
Copy link

@baylee-d baylee-d commented Dec 4, 2017

Purpose

In the case that a user enters in a ridiculously long tag, the tag won't break onto a new line. Instead, the tag will just stretch out of the bounds of the tag widget. We should make the tag break onto new line(s) when needed.

Summary of Changes

Add more styling to tags to prevent tags from going out of the tag-widget if there are REALLY long words.

Ticket

https://openscience.atlassian.net/browse/EOSF-949

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md (don't have initial release yet)

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@coveralls
Copy link

Coverage Status

Coverage increased (+2.0%) to 6.931% when pulling 5a4519d on baylee-d:feature/tag-word-break-overflow into 6d9a004 on CenterForOpenScience:develop.

@jamescdavis jamescdavis merged commit 904fa1f into CenterForOpenScience:develop Dec 4, 2017
@baylee-d baylee-d deleted the feature/tag-word-break-overflow branch January 17, 2018 15:57
@jamescdavis jamescdavis added this to the 0.1.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants