Skip to content

Conversation

@baylee-d
Copy link

@baylee-d baylee-d commented Dec 5, 2017

Purpose

When viewing quickfiles on smaller devices, the navbar displays weird behavior. The navbar should have styling changes that match expected behavior.

Summary of Changes

  • Set a min-height of elements to keep height of navbar consistent
  • Set margin-left for extra small screens to keep the element centered and off of the side
  • Set padding-left and padding-right to add more space between text and element's boundary
  • Add line-height to keep text centered vertically

** In the case of long names, more of the name will be displayed up to the edge of the page before overflowing
screen shot 2017-12-05 at 1 59 40 pm

** Once it gets to a certain point, it will overflow hidden
screen shot 2017-12-05 at 1 59 51 pm

screen shot 2017-12-05 at 2 00 02 pm

screen shot 2017-12-05 at 2 00 22 pm

screen shot 2017-12-05 at 2 00 33 pm

Ticket

https://openscience.atlassian.net/browse/EOSF-924

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md (don't have initial release yet)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 6.931% when pulling a9b2f12 on baylee-d:feature/make-navbar-mobile-friendly into b3b7fa0 on CenterForOpenScience:develop.

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please update to use latest ember-osf develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 6.931% when pulling afdda02 on baylee-d:feature/make-navbar-mobile-friendly into b3b7fa0 on CenterForOpenScience:develop.

@jamescdavis jamescdavis merged commit 2a578f5 into CenterForOpenScience:develop Dec 7, 2017
@baylee-d baylee-d deleted the feature/make-navbar-mobile-friendly branch January 17, 2018 15:57
@jamescdavis jamescdavis added this to the 0.1.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants