Serializer and adapter cleanup #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abought
changed the title
| accessToken = config.OSF.accessToken; | ||
| } else { | ||
| // Acquire an OSF access token, then exchange it for a Jam token | ||
| // Acquire an OSF access token, then exchange it for a Jam token // TODO: Jam? |
Contributor
There was a problem hiding this comment.
Shameless copy/paste. Will remove during merge.
| ENV.OSF.apiUrl = 'https://staging2-api.osf.io'; | ||
| ENV.OSF.authUrl = 'https://staging2-accounts.osf.io/oauth2/authorize'; | ||
| } | ||
| if (BACKEND === 'prod') { |
Contributor
There was a problem hiding this comment.
Probably shouldn't condone using prod as a backend for local development. If a dev needs a prod-like backend, they should use test.osf.io.
Contributor
There was a problem hiding this comment.
@sloria agreed, and I am trying to get the README to reflect this (we can be more explicit too), but the code should not assume that it's never being run in production.
Contributor
Author
There was a problem hiding this comment.
Adding support for the test backend got lost in the shuffle, but I agree it should be added for use by third-party integrators. Thanks for the reminder!
Presumably, prod is kept for use in deployment.
Contributor
There was a problem hiding this comment.
@samchrisinger As discussed in our other thread, envvars should be used for production and any non-local deploys.
aaxelb
added a commit
that referenced
this pull request
Oct 23, 2017
* [Feature] Update for reviews (#2) * Update models for reviews API * ReviewLog adapter and serializer * Fix log creator model * [Feature] Include reviewable when creating review logs (#3) * Include reviewable when creating review logs * Add title/contributors fields to preprint model * Clean up serializing relationships * Add dateLastTransitioned to preprint model (#5) * [Fix] Only fetch the logged in user once * Allow reviews settings to be nullable * Fix infinite authentication * Add support for using query parameters in findRecord * [Fix] Use `getRecords()` instead of `.record` (#8) * Tweaks and updates for reviews * Fix typo * [Feature][MOD-73] Rename log to action (minimal branch) (#2) * Rename `review-log` to `action` * plac8 flake8 * Fix test errors * [MOD-72][Feature] Add "My Reviews" for users with view_submissions permission * Add actions property to user model * Add `user` property to current-user instead * Add DOI alias properties to preprint model * Fix permissions check in navbar (#6) * Only serialize actually dirty relationships * Wait for currentUser.user to resolve (#8) * [Feature][MOD-111] Add preprint" button direct to the current provider's add page (#11) * Apply requested changes * rename * Apply requested changes * Fix * minor change * Apply requested change * Restore comment * Update search link * Use forked/fixed ember-data-has-many-query * Update ember-data-has-many-query dependency * Revert to non-forked ember-data-has-many-query * Update CHANGELOG
aaxelb
pushed a commit
that referenced
this pull request
Oct 26, 2017
…r's add page (#11) * Apply requested changes * rename * Apply requested changes * Fix * minor change * Apply requested change * Restore comment * Update search link
fabmiz
pushed a commit
that referenced
this pull request
Jul 17, 2020
…1.0.12 chore(deps): [security] bump fstream from 1.0.11 to 1.0.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/EOSF-3
Purpose
Start work on serializing data to send to server
Notes for Reviewers
extractAttributestest could be more elegant than it isThis PR had some trial and error; it's a good candidate for "merge and squash"
Routes Added/Updated
Blockers/ TODO