Skip to content

Conversation

@baylee-d
Copy link

@baylee-d baylee-d commented Jan 3, 2018

Purpose

Add ember-cli-clipboard to ember-osf for easier copying to clipboard.
Also allows copying to clipboards on Safari.

Summary of Changes

  • Add ember-cli-clipboard
  • Change clipboard buttons on revision table to use the new ember-cli-clipboard button

Ticket

https://openscience.atlassian.net/browse/EOSF-967

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@baylee-d
Copy link
Author

baylee-d commented Jan 3, 2018

Passing build:
https://travis-ci.org/baylee-d/ember-osf

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer and works in all browsers!

@jamescdavis jamescdavis merged commit a65b6cb into CenterForOpenScience:develop Jan 4, 2018
@baylee-d baylee-d deleted the feature/add-ember-clipboard branch January 17, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants