Skip to content

[IN-80][Ember-OSF] Change path of alias for highlighted_subjects for provider models #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2018
Merged

[IN-80][Ember-OSF] Change path of alias for highlighted_subjects for provider models #337

merged 1 commit into from
Jan 12, 2018

Conversation

@baylee-d
Copy link

@baylee-d baylee-d commented Jan 9, 2018 •
edited
Loading

Purpose

To change the preprint-provider model's hasHighlightedSubjects alias to point to the right place.

Summary of Changes

Remove data from beginning of path for hasHighlightedSubjects.

QA Notes

There shouldn't be any noticeable changes here.

Ticket

https://openscience.atlassian.net/browse/EOSF-884

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

jamescdavis
jamescdavis approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jamescdavis jamescdavis merged commit acd5601 into CenterForOpenScience:develop Jan 12, 2018
@baylee-d baylee-d deleted the feature/change-provider-model-highlighted-link-path branch January 17, 2018 15:53
@laurenbarker laurenbarker changed the title [EOSF-884] Change path of alias for highlighted_subjects for provider models [IN-80][Ember-OSF] Change path of alias for highlighted_subjects for provider models Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jamescdavis jamescdavis jamescdavis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baylee-d @jamescdavis