[EMB-60] Prevent user from selecting multiple files when clicking upload button. #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n if preventMultipleFiles is set
jamescdavis
suggested changes
Jan 23, 2018
Member
jamescdavis
left a comment
jamescdavis
left a comment
There was a problem hiding this comment.
See comments, and also, please update CHANGELOG
| // Therefore, we remove the "multiple" attribute for the hidden file input element, so that users cannot select | ||
| // multiple files for upload in the first place. | ||
| let clickableElement = this.get('clickable'); | ||
| if (this.options && this.options.preventMultipleFiles && clickableElement){ |
Member
There was a problem hiding this comment.
Should use this.get() e.g. this.get('options.preventMultipleFiles')
Member
There was a problem hiding this comment.
if (this.get('options.preventMultipleFiles') && this.get('clickableElement')) {
| // Dropzone.js does not have an option for disabling selecting multiple files when clicking the "upload" button. | ||
| // Therefore, we remove the "multiple" attribute for the hidden file input element, so that users cannot select | ||
| // multiple files for upload in the first place. | ||
| let clickableElement = this.get('clickable'); |
Member
There was a problem hiding this comment.
This variable is only used once and is probably not necessary.
Member
|
Passing build: https://travis-ci.org/adlius/ember-osf/builds/332877360 |
jamescdavis
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently for quickfiles, uploading multiple files by drag'n'drop is not allowed and would show "Cannot upload multiple files". However, this is not the case when user clicks the "upload" button and select multiple files to upload. This PR fix this problem by not allowing users to select multiple files for upload.
Summary of Changes
Dropzone.js handles drag'n'drop upload differently than clicking the "upload" button for upload. Therefore, there is not an event handler that we can override to prevent multiple uploads through clicking the "upload" button. However, we could remove the "multiple" attribute from the hidden
<input>element Dropzone uses, thus preventing users from selecting multiple files. And that is what is done in this PR.Side Effects / Testing Notes
None.
Ticket
https://openscience.atlassian.net/browse/EMB-60
Reviewer Checklist
CHANGELOG.md