Misc/resolve load all query has many compatibility #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescdavis
force-pushed
the
misc/resolve-loadAll-queryHasMany-compatibility
branch
from
8a566a5 to
cd2660c
Compare
aaxelb
approved these changes
Jan 22, 2018
Contributor
aaxelb
left a comment
aaxelb
left a comment
There was a problem hiding this comment.
Looks good! I suppose the fact this slipped through means we should probably have better tests around this... but in the interest of speedily fixing all the broken PRs, I think this is good.
Member
Author
Member
Author
|
Indeed! More tests! |
jamescdavis
deleted the
misc/resolve-loadAll-queryHasMany-compatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolve loadAll() / queryHasMany() compatibility.
Summary of Changes
Side Effects / Testing Notes
loadAll() works again?
Ticket
N/A
Reviewer Checklist
CHANGELOG.md