[EMB-102] Remove file-browser move-to-new-component functionality #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescdavis
changed the title
aaxelb
requested changes
Feb 9, 2018
Contributor
aaxelb
left a comment
aaxelb
left a comment
There was a problem hiding this comment.
Disable the cancel/back/move buttons as soon as you click "Move file"! If you click fast you can create a bunch of projects with the same name and it's a fun game to figure out which one actually has the file (hint: it's definitely not the one that "Go to new project" links to).
Other than that, looks solid 👍
Member
Author
|
Good idea and nice catch. |
jamescdavis
force-pushed
the
EMB-102_simplify_Move_to_Project_Workflow
branch
from
fa9aec8 to
15fafcd
Compare
jamescdavis
force-pushed
the
EMB-102_simplify_Move_to_Project_Workflow
branch
from
15fafcd to
a63183c
Compare
aaxelb
approved these changes
Feb 12, 2018
| this.get('i18n').t('eosf.components.moveToProject.couldNotMoveFile') | ||
| )); | ||
| )) | ||
| .then(() => this.set('isMoving', false)); |
Contributor
There was a problem hiding this comment.
It would be nice to refactor this component to use ember-concurrency tasks instead of chained promises, but that can be another time.
baylee-d
pushed a commit
to baylee-d/ember-osf
that referenced
this pull request
Feb 12, 2018
…nterForOpenScience#353) * Remove file-browser move to new component functionality * Update CHANGELOG * Disable "Cancel", "Back", and "Move file" buttons while moving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Simplify Quick Files move-to-project workflow by removing move to new component functionality
Summary of Changes
Side Effects / Testing Notes
Double check all verbiage.
Ticket
https://openscience.atlassian.net/browse/EMB-102
Reviewer Checklist
CHANGELOG.md