Skip to content

Conversation

@baylee-d
Copy link

Purpose

facebook_app_id was recently added to the preprint_provider model in osf.io. We should add it to the preprint-provider model in ember-osf to use it for sharing on branded preprints.

Summary of Changes

  • Added facebookAppId field to preprint-provider model

Side Effects / Testing Notes

This shouldn't affect anything other than adding a field to the model.

Ticket

https://openscience.atlassian.net/browse/IN-31

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@alexschiller alexschiller changed the title [IN-31][ember-osf] Add facebookAppId to preprint-provider model [IN-31][Ember-OSF] Add facebookAppId to preprint-provider model Feb 14, 2018
Copy link
Contributor

@alexschiller alexschiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🐨

@alexschiller alexschiller merged commit 6246a8c into CenterForOpenScience:release/next-interfaces Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants