Some misc updates #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also test embed behavior
- This forces routes to use pod structuring as well, which is not ideal
| // Embed contributors | ||
| return `${this._super(...arguments)}?embed=contributors`; | ||
| var base = this._super(...arguments); | ||
| if (requestType === 'GET') { |
Contributor
There was a problem hiding this comment.
I was recently looking along parallel lines... does this work? It seems like requestType is the Ember query type, not an HTTP method. See:
https://github.com/emberjs/data/blob/v2.5.1/addon/-private/adapters/build-url-mixin.js#L54
aaxelb
pushed a commit
that referenced
this pull request
Oct 26, 2017
fabmiz
pushed a commit
that referenced
this pull request
Jul 17, 2020
chore(deps): [security] bump atob from 2.0.3 to 2.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.