[SVCS-140] Fix to allow >= 31.0 setuptools #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
requested changes
Nov 8, 2017
cslzchen
changed the title
cslzchen
changed the title
cslzchen
reviewed
Nov 13, 2017
| @@ -0,0 +1 @@ | |||
| __version__ = '0.20.1' | |||
Contributor
There was a problem hiding this comment.
@felliott this will be the file that needs manual version bump for release/hotfix
@Johnetordoff need to update this to 0.22.0
cslzchen
requested changes
Nov 21, 2017
Contributor
There was a problem hiding this comment.
@Johnetordoff
I locally tested the code, here are a few issues:
- need to update the
__version__import insetup.py - need to rebase your change up-to-date-develop and make only one commit
- update the version to 0.22.0 and fix conflicts
@felliott We probably need to target this for next hotfix or release since each new version will cause merge conflicts.
Contributor
|
And a follow-up: we should update the version of |
This was referenced Nov 21, 2017
Contributor
|
In addition, there are a few other places, for example |
Contributor
|
@Johnetordoff this continues in a new PR: #301 where I fixed a few minor issues and rebase all the commits into one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Let MFR run later versions of setuptools (>= 31.0 setuptools)
Changes
Creates version.py file to prevent setuptools to prevent circular import.
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/SVCS-140
WB PR
CenterForOpenScience/waterbutler#201