Fix to rendering of .omv files with images in them #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added appropriate test
Member
|
Merged and verified on our testing environment. I'll update production once travis finishes. Thanks, @jonathon-love! |
Member
|
Deployed! |
Contributor
Author
|
thanks @felliott! i was worried it was going to take 4 months to be deployed, so to have a turn around in less than 24 hours is super appreciated! jonathon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes a bug in the rendering of .omv files which contain images. (Image urls containing
%20were not decoded back to spaces, and reading images from the archive was failing.)Changes
Image urls are now decoded correctly
Side effects
None
QA Notes
An additional test has been added to the jamovi tests
Deployment Notes
Nope