Skip to content

Conversation

@NyanHelsing
Copy link
Contributor

@NyanHelsing NyanHelsing commented Mar 8, 2018

Ticket

https://openscience.atlassian.net/browse/SVCS-645

Purpose

Adds Hypothesis annotations to pdfs only inside the iframe.

Changes

Side effects

Users with the hypothesis extension will experience some weirdness.

QA Notes

Deployment Notes

Add PDF_EXTENSION_CONFIG_ENABLE_HYPOTHESIS=1 to .docker-compose.mfr.env to enable.

@coveralls
Copy link

coveralls commented Mar 8, 2018

Coverage Status

Coverage increased (+0.01%) to 72.378% when pulling 20599fe on birdbrained:ft/hypothesis-stopgap into c8ffa75 on CenterForOpenScience:develop.

@felliott felliott closed this in fc0d556 Apr 12, 2018
@felliott
Copy link
Member

Thanks, @birdbrained! Merged at long last!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants