[SVCS-571] Fix Image Hi-Res and Zoom for IE #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IE does not automatically resize images to fit window size. Explicitly set max-width=100% and height=auto to fix this issue.
cslzchen
commented
Mar 22, 2018
Contributor
Author
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
It turns out to be easy than I thought. I was afraid that the library we use does not support IE but fortunately they do. We simply need to explicitly set the CSS for IE.
Instead of making an "IE-special" condition, I updated the CSS in general. Verified in local environment that this fix IE and does not break the others.
Ready for CR 🎆 🎆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/SVCS-571
Purpose
Fix the issue that IE does not resize image to fit window size.
Changes
Explicitly set
"max-width": "100%"and"height": "auto".Side effects
No
QA Notes
Test small, medium and large files on IE for this fix and on other supported browsers to make sure that nothing breaks.
Deployment Notes
No