[HotFix] [SVCS-676] Fix Memory Leak During CSV Rendering #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
commented
Mar 29, 2018
| options=json.dumps(size), | ||
| ) | ||
| # gc.collect() | ||
| raise exceptions.TableTooBigError( |
Contributor
Author
There was a problem hiding this comment.
Raise exception after with open() has finished.
mfr/extensions/tabular/render.py
Outdated
| sheets=json.dumps(sheets), | ||
| options=json.dumps(size), | ||
| ) | ||
| # gc.collect() |
Contributor
Author
There was a problem hiding this comment.
Forcing garbage collection does not help, which is a good thing. I will remove the import and these statement after CR.
| break | ||
|
|
||
| if table_too_big: | ||
| return None, None, nbr_rows, nbr_cols |
Contributor
Author
There was a problem hiding this comment.
This is an ugly way of using python's flexibility. Please advise!
cslzchen
force-pushed
the
bug-fix/csv-memory-leak
branch
from
a740bf9 to
cb812b9
Compare
- Delay exception raising until context manager `with open()` has finished. - _render_grid now returns a four element tuple (sheets, size, nbr_rows, nbr_cols), where the first two for success and the last two for the `TableTooLargeError`.
- Delay return until Context Manager `with open()` has finished and force GC in between. - Explicitly `del` data, reader, sheets when they are on longer used.
cslzchen
force-pushed
the
bug-fix/csv-memory-leak
branch
from
cb812b9 to
4aed951
Compare
cslzchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSVare correctly rendered. Need more investigation.TableTooBigErrorexception is thrown.