-
Notifications
You must be signed in to change notification settings - Fork 351
ENG-5751 remove old keen logic #10992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ee7c18a
873a011
f20d0e7
b6cd855
5c2255e
f081bd2
4df563c
4cf4dc7
3c86081
096f519
1e2eb30
5456bca
801c95f
0fe5548
51f23d7
530c57e
822b829
de3b4aa
af03db3
35ad648
18e6fbd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, and I guess axing
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you should also be good to delete the commented-out code. If we decide to reimplement these later, we can always dig into the git history. |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this file you should also be able to remove
client,publicClient,renderKeenClient, and anything involvingkeen-analysis.keen-datavizis still used to render charts from our internal metrics, so that should be left alone. Removingkeen-analysisfrom here should allow you to remove it from admin'spackage.json/yarn.locktoo.