[ENG-7729] | migrated WaterButler to Poetry for dependency management #11102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felliott
requested changes
Apr 24, 2025
Member
felliott
left a comment
felliott
left a comment
There was a problem hiding this comment.
We don't want to get rid of the wb_requirements container entirely. It lets us rebuild dependency changes while developing waterbutler. I'm not sure if we still need the local_bin volume though. We might need newrelic binaries to run WB with NR monitoring.
Member
|
Looks good! Merging. |
felliott
merged commit aea245a
into
CenterForOpenScience:feature/buff-worms-wb
5 of 6 checks passed
cslzchen
added a commit
that referenced
this pull request
Aug 8, 2025
* [ENG-7729] Migrated WaterButler to Poetry for dependency management (#11102) * [ENG-8414] Fix WB logging payloads (#11244) --------- Co-authored-by: Andriy Sheredko <sheredko.andriy@gmail.com> Co-authored-by: Fitz Elliott <fitz@cos.io> Co-authored-by: Vlad0n20 <137097005+Vlad0n20@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate WaterButler to Poetry for dependency management
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
ENG-7729