[ENG-7810] improve action requests creation #11109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
force-pushed
the
fix-moderator-permission-actions
branch
from
29db28b to
56de5df
Compare
Johnetordoff
force-pushed
the
fix-moderator-permission-actions
branch
from
56de5df to
2e8421a
Compare
Johnetordoff
changed the title
brianjgeiger
approved these changes
Apr 28, 2025
brianjgeiger
merged commit 094decf
into
CenterForOpenScience:feature/pbs-25-09
6 checks passed
ihorsokhanexoft
pushed a commit
to ihorsokhanexoft/osf.io
that referenced
this pull request
Jun 4, 2025
## Purpose Fix's a 502 that happened when the permission's class hit a NoneType target id ## Changes - improves tests - adds validation for target ids ## Ticket https://openscience.atlassian.net/browse/ENG-7810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix's a 502 that happened when the permission's class hit a NoneType target id
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-7810