Skip to content

Conversation

@ihorsokhanexoft
Copy link
Contributor

@ihorsokhanexoft ihorsokhanexoft commented Apr 28, 2025

Purpose

Admins should be able to see number of messages that each admin sent to the same user

Changes

Added contact property, added a test and fixed existing ones
Contacts are ordered alphabetically
Additional scope: this property was added in export files as well

Ticket

https://openscience.atlassian.net/jira/software/c/projects/ENG/boards/145

Copy link
Collaborator

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what I don't like about this solution is that it's going to run that query, with the annotation, on every user on the page when it loads the page. This is going to create additional unnecessary stress on the database, which is what I was trying to avoid.

On the plus side, it does allow us to implement the feature in the way that Product originally wanted, which was to display the count for all users at the start rather than waiting until they hovered over the contact balloon.

We'll go with this, unless we find that the page slowdown is noticeable. Fortunately, these pages don't get used that often all things considered, so we shouldn't be taking down the OSF with it. But if we were making an endpoint that had publicly-accessible data, this would not be the way to do it.

@brianjgeiger brianjgeiger changed the base branch from feature/pbs-25-08 to feature/pbs-25-09 May 2, 2025 13:32
@brianjgeiger brianjgeiger merged commit 2508c9b into CenterForOpenScience:feature/pbs-25-09 May 2, 2025
6 checks passed
ihorsokhanexoft added a commit to ihorsokhanexoft/osf.io that referenced this pull request Jun 4, 2025
…#11115)

## Purpose
Admins should be able to see number of messages that each admin sent to the same user

## Changes
Added contact property, added a test and fixed existing ones
Contacts are ordered alphabetically
Additional scope: this property was added in export files as well

## Ticket
https://openscience.atlassian.net/jira/software/c/projects/ENG/boards/145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants