[ENG-7879] Ability to resync preprints that have missing doi with Crossref #11121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
requested changes
May 1, 2025
Collaborator
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
One very minor CSS thing, and one concern about how the async loop is going to work.
Comment on lines
63
to
70
| def sync_preprint_missing_dois(self): | ||
| preprints = Preprint.objects.filter(preprint_doi_created=None) | ||
| for preprint in preprints: | ||
| try: | ||
| preprint.request_identifier_update('doi', create=True) | ||
| except Exception as err: | ||
| logger.warning(f'[{err.__class__.__name__}] Doi creation failed for the preprint with id {preprint._id} because of error: {err}') | ||
| self.retry() |
Collaborator
There was a problem hiding this comment.
This is a little weird, because five failed preprints will stop this whole loop from happening. Would it make more sense to just modify the sync_doi_metadata list of things to sync in the case of missing_preprint_dois_only or, failing that, make this function work more like the sync_doi_metadata function does?
Contributor
Author
There was a problem hiding this comment.
Yeah, this is how I intended it to work but missed running each request_identifier_update as a separate task with its own retry, not the general one
brianjgeiger
approved these changes
May 1, 2025
brianjgeiger
merged commit b2efad2
into
CenterForOpenScience:feature/pbs-25-09
6 checks passed
ihorsokhanexoft
added a commit
to ihorsokhanexoft/osf.io
that referenced
this pull request
Jun 4, 2025
…ssref (CenterForOpenScience#11121) ## Purpose Admins should be able to resync preprints without minted doi with Crossref instead of all preprints. ## Changes 1. Added check mark for syncing only preprints without minted DOI. Fixed text coloring that has red background and red text color 2. Improved retry functionality for sync_identifier_doi task 3. Created a new celery task to resync preprints missing DOI and after that exclude all preprints from identifiers queryset ## Ticket https://openscience.atlassian.net/browse/ENG-7879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Admins should be able to resync preprints without minted doi with Crossref instead of all preprints.
Changes
Ticket
https://openscience.atlassian.net/browse/ENG-7879?atlOrigin=eyJpIjoiZWRiM2Q0ZWI4YzZlNGRlOTg5NDMzMmRjZWQ5YjQ2NjkiLCJwIjoiaiJ9