Feature/pbs 25 08 #11124
Merged
Feature/pbs 25 08 #11124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
double-quote-string-fixer
## Purpose When user has a deleted node where he is the only admin, osf admin can't gdpr delete this user because of this error ## Changes Ignore this message for deleted nodes. Added a test ## Ticket https://openscience.atlassian.net/browse/ENG-7557
[ENG-7792] Remove unused tests to speed up CI
…Admin App (#11105) ## Purpose Implement Force Archive for admin UI based on `osf/management/commands/force_archive.py` ## Changes BE: 1. remove globals from force archive management command to make it thread-safe (usable in views) 2. Implement CheckArchiveStatusRegistrationsView and ForceArchiveRegistrationsView 3. RestartStuckRegistrationsView is replaced with ForceArchiveRegistrationsView FE: 1. Added Check archive status button 2. Added Force Archive button 3. Updated Restart Stuck Registration button (now it'll open the same modal as Force Archive to choose parameters but dry-mode is not available) ## QA Notes - Check archive status is displayed if node is registration - Force Archive button is displayed if registration is not archived and not stuck - Restart/Remove Stuck Registration are displayed if registration is not archived and stuck ## Ticket https://openscience.atlassian.net/browse/ENG-7270
## Purpose `Preprint` inherits from `VersionedGuidMixin` that inherits from `GuidMixin` thus `coerce_guid` tries to fetch guid from `guids` attribute instead of `versioned_guids` ## Changes Added if statement ## Ticket https://openscience.atlassian.net/browse/ENG-7798
## Purpose Fix bug with citations for a new preprint version. The problem was in the process of creating a version of the preprint, so also added the manage command to fix already created versions ## Changes Fix bug with citations for a new preprint version ## Ticket https://openscience.atlassian.net/browse/ENG-7263
…n_callbacks [ENG-7740] Upgrade Archiver Callbacks
## Purpose Fix preprint updating ## Changes Add a manage command to fix why_no_data and has_data_links for broken preprints due to an unknown bug on FE (Futa described it in the comments to the ticket) ## Ticket https://openscience.atlassian.net/browse/ENG-7503
## Purpose clean up code we don't need anymore (and avoid error messages when CenterForOpenScience/SHARE#859 ) ## Changes contains #11012
…h date uploaded) via the admin app (#11097) ## Purpose Add "Create new version 1" button on admin UI ## Changes - Add button to admin UI - Extend existing preprint versioning functionality - Move permission validation logic from serializer to model level to keep everything in one place - add required_permission decorator (with ignore_permission functionality) that checks if user has enough permission to call method ## QA Notes Expected behavior: 1. Admin goes the preprint admin page 2. Clicks "Create new version 1", a modal asking to choose date will be displayed 3. If date is valid and file versions exists: - a new version 1 will be created - admin user will be redirected to v1 - optionally, admin user can make new preprint published by clicking "Make published" button (!) Preprint guid should point to the latest version, not the newly created one. (!) Admin should be able to create new versions of a preprint even if they are not a contributor. ## Ticket https://openscience.atlassian.net/browse/ENG-7716
<!-- Before submit your Pull Request, make sure you picked
the right branch:
- For hotfixes, select "master" as the target branch
- For new features, select "develop" as the target branch
- For release feature fixes, select the relevant release branch (release/X.Y.Z) as the target branch -->
## Purpose
fix for non-contributor admin
## Changes
- add ignore_permission to set_license
- prevent creating new preprint version when serializer raises error
https://openscience.atlassian.net/browse/ENG-7716
## Purpose Fix the errors in the management command ## Changes Remove useless parameter ## Ticket https://openscience.atlassian.net/browse/ENG-7263
…h date uploaded) via the admin app (#11118) ## Purpose improve exception handling and minor fixes ## Changes - improve exception handling - supplemental node permission error - set subjects from relationship to keep valid hierarchy - ignore unfinished/unpublished versions ## Ticket https://openscience.atlassian.net/browse/ENG-7716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Merge PB&S feature branch 25-08 to develop.