[ENG-7871] Removed restrictions that prohibit options deletion #11128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjgeiger
requested changes
May 6, 2025
Collaborator
brianjgeiger
left a comment
brianjgeiger
left a comment
There was a problem hiding this comment.
Looks like there are more validations, just named differently. For example, https://github.com/CenterForOpenScience/osf.io/pull/11128/files#diff-969afa4ce0bf035d02c22534e02e7be4677ec667df83699bbd1aa27d2fbb911cL232-L235
brianjgeiger
approved these changes
May 6, 2025
brianjgeiger
merged commit 1fe3759
into
CenterForOpenScience:feature/pbs-25-09
6 checks passed
ihorsokhanexoft
added a commit
to ihorsokhanexoft/osf.io
that referenced
this pull request
Jun 4, 2025
…rForOpenScience#11128) ## Purpose Admins should be able to remove collections options without any restrictions ## Changes Removed validation ## Ticket https://openscience.atlassian.net/browse/ENG-7871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Admins should be able to remove collections options without any restrictions
Changes
Removed validation
Ticket
https://openscience.atlassian.net/browse/ENG-7871?atlOrigin=eyJpIjoiZWJmZDUxZDM1YTZlNGZiNGFiNTBmMjZhZDVmNDhhZGQiLCJwIjoiaiJ9