[ENG-8868] File Operation: No notifications sent when file upload failed #11295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnetordoff
requested changes
Sep 12, 2025
Contributor
Johnetordoff
left a comment
Johnetordoff
left a comment
There was a problem hiding this comment.
Just add a unit test case for this and it's good. 👍
Johnetordoff
force-pushed
the
add-new-notifications-data-model
branch
from
8e149ea to
054fe23
Compare
Johnetordoff
merged commit 936a4e1
into
CenterForOpenScience:add-new-notifications-data-model
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix file operation notifications
Changes
See diff
QA Notes
FILE_OPERATION_FAILED and FILE_OPERATION_SUCCESS are only sent during file_moved and file_copied operations
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-8868